-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ansible remediation for account_password_selinux_faillock_dir #12094
Add ansible remediation for account_password_selinux_faillock_dir #12094
Conversation
For the account_password_selinux_faillock_dir rule Signed-off-by: Armando Acosta <[email protected]>
Hi @mrkanon. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This datastream diff is auto generated by the check Click here to see the full diffNew data stream adds ansible remediation for rule 'xccdf_org.ssgproject.content_rule_account_password_selinux_faillock_dir'. |
Change in Ansible Please consider using more suitable Ansible module than |
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
Code Climate has analyzed commit 8458b45 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have built RHEL 9 product and reviewed the generated Ansible task and executed tests against a RHEL 9 virtual machine.
Description:
Add ansible remediation for
account_password_selinux_faillock_dir
ruleRationale:
In the task filling gaps in OL9 automation, the rule
account_password_selinux_faillock_dir
has a remediation deficit with ansible. The logic of the remediation was taken of bash remediation